Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2290553003: [api] Add documentation for PropertyAttribute enum. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add documentation for the PropertyAttribute enum. Add comments to make it easier to browse the HTML documentation generated with Doxygen. BUG=v8:5260 Committed: https://crrev.com/25e2d1588eb519c3f4657f768362f8b55cbd062d Cr-Commit-Position: refs/heads/master@{#38982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M include/v8.h View 1 chunk +10 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Franzi
PTAL.
4 years, 3 months ago (2016-08-29 12:39:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-29 12:52:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290553003/1
4 years, 3 months ago (2016-08-29 12:56:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 13:22:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 13:22:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25e2d1588eb519c3f4657f768362f8b55cbd062d
Cr-Commit-Position: refs/heads/master@{#38982}

Powered by Google App Engine
This is Rietveld 408576698