Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 229053002: Revert of Fix sticky keys crash when handling synthetic events without a native event. (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
Reviewers:
Tim Song, sadrul
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Fix sticky keys crash when handling synthetic events without a native event. (https://codereview.chromium.org/227113009/) Reason for revert: Breaks compile on Linux ChromiumOS (Clang dbg) .../sticky_keys_unittest.cc:848:3:error: ignoring return value of function declared with warn_unused_result attribute [-Werror,-Wunused-result] dispatcher->OnEventFromSource(kev.get()); (and 2 more) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20%28Clang%20dbg%29/builds/922/ Original issue's description: > Fix sticky keys crash when handling synthetic events without a native event. > > BUG=358270 > TEST=modified tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262465 TBR=sadrul@chromium.org,tengs@chromium.org NOTREECHECKS=true NOTRY=true BUG=358270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -96 lines) Patch
M ash/sticky_keys/sticky_keys_controller.h View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/sticky_keys/sticky_keys_controller.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 6 chunks +18 lines, -77 lines 0 comments Download
M ui/events/event.h View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Fix sticky keys crash when handling synthetic events without a native event.
6 years, 8 months ago (2014-04-08 19:23:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/229053002/1
6 years, 8 months ago (2014-04-08 19:23:20 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 19:24:18 UTC) #3
Message was sent while issue was closed.
Change committed as 262469

Powered by Google App Engine
This is Rietveld 408576698