Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2290523004: Move onMouseDown from WebWidgetClient to WebViewClient. (Closed)
Patch Set: adding todo Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/public/web/WebWidgetClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebViewClient.h
diff --git a/third_party/WebKit/public/web/WebViewClient.h b/third_party/WebKit/public/web/WebViewClient.h
index 996b7730254c8e210de0247b914af84f4f6cb0b6..9e55f42979962d2145253e07f10ce1840f695b6b 100644
--- a/third_party/WebKit/public/web/WebViewClient.h
+++ b/third_party/WebKit/public/web/WebViewClient.h
@@ -196,6 +196,14 @@ public:
// Called when the View acquires focus.
virtual void didFocus() {}
+ // TODO(lfg): The callback below is exposed in RenderViewObserver and only
+ // used to implement autofill. We should figure out a better way to plumb
+ // this.
+ // Called immediately after a mousedown event is dispatched due to a mouse
+ // press or gesture tap.
+ // Note: This is called even when the mouse down event is prevent default.
+ virtual void onMouseDown(const WebNode& mouseDownNode) { }
+
// Session history -----------------------------------------------------
// Tells the embedder to navigate back or forward in session history by
@@ -266,7 +274,6 @@ public:
void didUpdateTextOfFocusedElementByNonUserInput() override {}
void hasTouchEventHandlers(bool) override {}
void initializeLayerTreeView() override {}
- void onMouseDown(const WebNode& mouseDownNode) override {}
void resetInputMethod() override {}
WebScreenInfo screenInfo() override { return WebScreenInfo(); }
void setToolTipText(const WebString&, WebTextDirection hint) override {}
« no previous file with comments | « no previous file | third_party/WebKit/public/web/WebWidgetClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698