Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: components/omnibox/browser/shortcuts_backend_unittest.cc

Issue 2290503003: Remove use of stl_util in search_engines. (Closed)
Patch Set: ios for reals Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/shortcuts_backend_unittest.cc
diff --git a/components/omnibox/browser/shortcuts_backend_unittest.cc b/components/omnibox/browser/shortcuts_backend_unittest.cc
index 2cd6235e40977bf61874e3b1cb5871f77b92748b..e50e81f9f0598284e214474485c38df34dce09e8 100644
--- a/components/omnibox/browser/shortcuts_backend_unittest.cc
+++ b/components/omnibox/browser/shortcuts_backend_unittest.cc
@@ -104,9 +104,10 @@ void ShortcutsBackendTest::SetSearchProvider() {
data.SetShortName(base::UTF8ToUTF16("foo"));
data.SetKeyword(base::UTF8ToUTF16("foo"));
- TemplateURL* template_url = new TemplateURL(data);
- // Takes ownership of |template_url|.
- template_url_service_->Add(template_url);
+ std::unique_ptr<TemplateURL> template_url_ptr =
+ base::MakeUnique<TemplateURL>(data);
+ TemplateURL* template_url = template_url_ptr.get();
+ template_url_service_->Add(std::move(template_url_ptr));
Peter Kasting 2016/08/31 04:12:56 Nit: Just use the old code and add a WrapUnique()
Avi (use Gerrit) 2016/09/01 00:34:26 Done.
template_url_service_->SetUserSelectedDefaultSearchProvider(template_url);
}

Powered by Google App Engine
This is Rietveld 408576698