Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/omnibox/browser/keyword_provider_unittest.cc

Issue 2290503003: Remove use of stl_util in search_engines. (Closed)
Patch Set: ios for reals Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/keyword_provider_unittest.cc
diff --git a/components/omnibox/browser/keyword_provider_unittest.cc b/components/omnibox/browser/keyword_provider_unittest.cc
index 9b89345cf04fc53f6ad6a5d0fa042142172cb367..a4266e4123c3b5a76ea71ec24694f30822bb8d21 100644
--- a/components/omnibox/browser/keyword_provider_unittest.cc
+++ b/components/omnibox/browser/keyword_provider_unittest.cc
@@ -9,6 +9,7 @@
#include "base/command_line.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h"
#include "base/strings/utf_string_conversions.h"
@@ -428,8 +429,10 @@ TEST_F(KeywordProviderTest, AddKeyword) {
base::string16 keyword(ASCIIToUTF16("foo"));
data.SetKeyword(keyword);
data.SetURL("http://www.google.com/foo?q={searchTerms}");
- TemplateURL* template_url = new TemplateURL(data);
- client_->GetTemplateURLService()->Add(template_url);
+ std::unique_ptr<TemplateURL> template_url_ptr =
+ base::MakeUnique<TemplateURL>(data);
+ TemplateURL* template_url = template_url_ptr.get();
+ client_->GetTemplateURLService()->Add(std::move(template_url_ptr));
Peter Kasting 2016/08/31 04:12:56 Nit: Just use the old code and add a WrapUnique()
Avi (use Gerrit) 2016/09/01 00:34:26 Done.
ASSERT_TRUE(
template_url ==
client_->GetTemplateURLService()->GetTemplateURLForKeyword(keyword));

Powered by Google App Engine
This is Rietveld 408576698