Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/ui/search/instant_test_utils.cc

Issue 2290503003: Remove use of stl_util in search_engines. (Closed)
Patch Set: fix broken test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_test_utils.cc
diff --git a/chrome/browser/ui/search/instant_test_utils.cc b/chrome/browser/ui/search/instant_test_utils.cc
index b8dc7ae1aa053d7ed97e9700a94aaf71e68fa3a4..3dfe0ee4ab70fa6c49ffcd57d7a01be29c58039b 100644
--- a/chrome/browser/ui/search/instant_test_utils.cc
+++ b/chrome/browser/ui/search/instant_test_utils.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile.h"
@@ -63,8 +64,7 @@ void InstantTestBase::SetupInstant(Browser* browser) {
data.alternate_urls.push_back(instant_url_.spec() + "#q={searchTerms}");
data.search_terms_replacement_key = "strk";
- TemplateURL* template_url = new TemplateURL(data);
- service->Add(template_url); // Takes ownership of |template_url|.
+ TemplateURL* template_url = service->Add(base::MakeUnique<TemplateURL>(data));
service->SetUserSelectedDefaultSearchProvider(template_url);
}
@@ -78,8 +78,7 @@ void InstantTestBase::SetInstantURL(const std::string& url) {
data.SetURL(url);
data.instant_url = url;
- TemplateURL* template_url = new TemplateURL(data);
- service->Add(template_url); // Takes ownership of |template_url|.
+ TemplateURL* template_url = service->Add(base::MakeUnique<TemplateURL>(data));
service->SetUserSelectedDefaultSearchProvider(template_url);
}

Powered by Google App Engine
This is Rietveld 408576698