chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc - Issue 2290503003: Remove use of stl_util in search_engines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

Issue 2290503003: Remove use of stl_util in search_engines. (Closed)

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/search_engines/edit_search_engine_controller.cc ('K') | « chrome/browser/ui/search_engines/edit_search_engine_controller.cc ('k') | chrome/browser/ui/search_engines/search_engine_tab_helper.cc » ('j') | components/omnibox/browser/history_url_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

diff --git a/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc b/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

index f982d81ccf26e3730a3409db9e0aa022c3af32ff..6cefe1c775c7802a944b3a58d1f234d90780a97d 100644

--- a/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

+++ b/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/compiler_specific.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/profiles/profile.h"

@@ -244,8 +245,7 @@ TEST_F(KeywordEditorControllerTest, MutateTemplateURLService) {

TemplateURLData data;

data.SetShortName(ASCIIToUTF16("b"));

data.SetKeyword(ASCIIToUTF16("a"));

- TemplateURL* turl = new TemplateURL(data);

- util()->model()->Add(turl);

+ TemplateURL* turl = util()->model()->Add(base::MakeUnique<TemplateURL>(data));

// Table model should have updated.

VerifyChangeCount(1, 0, 0, 0);