Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "components/omnibox/browser/scored_history_match.h" | 5 #include "components/omnibox/browser/scored_history_match.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 #include <memory> | 8 #include <memory> |
| 9 | 9 |
| 10 #include "base/auto_reset.h" | 10 #include "base/auto_reset.h" |
| (...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 305 Make1Term("testsearch"), one_word_no_offset, | 305 Make1Term("testsearch"), one_word_no_offset, |
| 306 word_starts, false, template_url_service.get(), | 306 word_starts, false, template_url_service.get(), |
| 307 now); | 307 now); |
| 308 EXPECT_GT(scored_b.raw_score, 0); | 308 EXPECT_GT(scored_b.raw_score, 0); |
| 309 | 309 |
| 310 // Set up a default search engine associated with this URL. | 310 // Set up a default search engine associated with this URL. |
| 311 TemplateURLData data; | 311 TemplateURLData data; |
| 312 data.SetShortName(ASCIIToUTF16("TestEngine")); | 312 data.SetShortName(ASCIIToUTF16("TestEngine")); |
| 313 data.SetKeyword(ASCIIToUTF16("TestEngine")); | 313 data.SetKeyword(ASCIIToUTF16("TestEngine")); |
| 314 data.SetURL("http://testsearch.com/{searchTerms}"); | 314 data.SetURL("http://testsearch.com/{searchTerms}"); |
| 315 TemplateURL* template_url = new TemplateURL(data); | 315 std::unique_ptr<TemplateURL> template_url_ptr = |
| 316 template_url_service->Add(template_url); | 316 base::MakeUnique<TemplateURL>(data); |
| 317 TemplateURL* template_url = template_url_ptr.get(); | |
| 318 template_url_service->Add(std::move(template_url_ptr)); | |
|
Peter Kasting
2016/08/31 04:12:56
Nit: Just use the old code and add a WrapUnique()
Avi (use Gerrit)
2016/09/01 00:34:26
Done.
| |
| 317 template_url_service->SetUserSelectedDefaultSearchProvider(template_url); | 319 template_url_service->SetUserSelectedDefaultSearchProvider(template_url); |
| 318 template_url_service->Load(); | 320 template_url_service->Load(); |
| 319 | 321 |
| 320 // The search results page should not be returned when typing a query. | 322 // The search results page should not be returned when typing a query. |
| 321 ScoredHistoryMatch scored_c(row, visits, ASCIIToUTF16("thequery"), | 323 ScoredHistoryMatch scored_c(row, visits, ASCIIToUTF16("thequery"), |
| 322 Make1Term("thequery"), one_word_no_offset, | 324 Make1Term("thequery"), one_word_no_offset, |
| 323 word_starts, false, template_url_service.get(), | 325 word_starts, false, template_url_service.get(), |
| 324 now); | 326 now); |
| 325 EXPECT_EQ(0, scored_c.raw_score); | 327 EXPECT_EQ(0, scored_c.raw_score); |
| 326 | 328 |
| (...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 654 | 656 |
| 655 EXPECT_TRUE( | 657 EXPECT_TRUE( |
| 656 ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets)); | 658 ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets)); |
| 657 EXPECT_THAT(hqp_buckets, ElementsAre(Pair(0.0, 400), Pair(1.5, 600), | 659 EXPECT_THAT(hqp_buckets, ElementsAre(Pair(0.0, 400), Pair(1.5, 600), |
| 658 Pair(12.0, 1300), Pair(20.0, 1399))); | 660 Pair(12.0, 1300), Pair(20.0, 1399))); |
| 659 // invalid string. | 661 // invalid string. |
| 660 buckets_str = "0.0,400,1.5,600"; | 662 buckets_str = "0.0,400,1.5,600"; |
| 661 EXPECT_FALSE( | 663 EXPECT_FALSE( |
| 662 ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets)); | 664 ScoredHistoryMatch::GetHQPBucketsFromString(buckets_str, &hqp_buckets)); |
| 663 } | 665 } |
| OLD | NEW |