Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc

Issue 2290503003: Remove use of stl_util in search_engines. (Closed)
Patch Set: fix broken test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h" 5 #include "chrome/browser/android/contextualsearch/contextual_search_delegate.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "base/base64.h" 11 #include "base/base64.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/memory/ptr_util.h"
13 #include "base/message_loop/message_loop.h" 14 #include "base/message_loop/message_loop.h"
14 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
15 #include "base/values.h" 16 #include "base/values.h"
16 #include "chrome/browser/android/contextualsearch/contextual_search_context.h" 17 #include "chrome/browser/android/contextualsearch/contextual_search_context.h"
17 #include "chrome/browser/android/contextualsearch/resolved_search_term.h" 18 #include "chrome/browser/android/contextualsearch/resolved_search_term.h"
18 #include "chrome/browser/android/proto/client_discourse_context.pb.h" 19 #include "chrome/browser/android/proto/client_discourse_context.pb.h"
19 #include "components/search_engines/template_url_service.h" 20 #include "components/search_engines/template_url_service.h"
20 #include "net/base/escape.h" 21 #include "net/base/escape.h"
21 #include "net/url_request/test_url_fetcher_factory.h" 22 #include "net/url_request/test_url_fetcher_factory.h"
22 #include "net/url_request/url_request_test_util.h" 23 #include "net/url_request/url_request_test_util.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 display_text_ = "unknown"; 62 display_text_ = "unknown";
62 context_language_ = ""; 63 context_language_ = "";
63 } 64 }
64 65
65 TemplateURLService* CreateTemplateURLService() { 66 TemplateURLService* CreateTemplateURLService() {
66 // Set a default search provider that supports Contextual Search. 67 // Set a default search provider that supports Contextual Search.
67 TemplateURLData data; 68 TemplateURLData data;
68 data.SetURL("https://foobar.com/url?bar={searchTerms}"); 69 data.SetURL("https://foobar.com/url?bar={searchTerms}");
69 data.contextual_search_url = "https://foobar.com/_/contextualsearch?" 70 data.contextual_search_url = "https://foobar.com/_/contextualsearch?"
70 "{google:contextualSearchVersion}{google:contextualSearchContextData}"; 71 "{google:contextualSearchVersion}{google:contextualSearchContextData}";
71 TemplateURL* template_url = new TemplateURL(data);
72 // Takes ownership of |template_url|.
73 TemplateURLService* template_url_service = new TemplateURLService(NULL, 0); 72 TemplateURLService* template_url_service = new TemplateURLService(NULL, 0);
74 template_url_service->Add(template_url); 73 TemplateURL* template_url =
74 template_url_service->Add(base::MakeUnique<TemplateURL>(data));
75 template_url_service->SetUserSelectedDefaultSearchProvider(template_url); 75 template_url_service->SetUserSelectedDefaultSearchProvider(template_url);
76 return template_url_service; 76 return template_url_service;
77 } 77 }
78 78
79 void CreateDefaultSearchContextAndRequestSearchTerm() { 79 void CreateDefaultSearchContextAndRequestSearchTerm() {
80 base::string16 surrounding = base::UTF8ToUTF16("Barack Obama just spoke."); 80 base::string16 surrounding = base::UTF8ToUTF16("Barack Obama just spoke.");
81 CreateSearchContextAndRequestSearchTerm("Barack Obama", surrounding, 0, 6); 81 CreateSearchContextAndRequestSearchTerm("Barack Obama", surrounding, 0, 6);
82 } 82 }
83 83
84 void CreateSearchContextAndRequestSearchTerm( 84 void CreateSearchContextAndRequestSearchTerm(
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 EXPECT_EQ("obama", display_text()); 531 EXPECT_EQ("obama", display_text());
532 EXPECT_EQ("/m/02mjmr", mid()); 532 EXPECT_EQ("/m/02mjmr", mid());
533 EXPECT_TRUE(do_prevent_preload()); 533 EXPECT_TRUE(do_prevent_preload());
534 EXPECT_EQ("de", context_language()); 534 EXPECT_EQ("de", context_language());
535 } 535 }
536 536
537 TEST_F(ContextualSearchDelegateTest, HeaderContainsBasePageUrl) { 537 TEST_F(ContextualSearchDelegateTest, HeaderContainsBasePageUrl) {
538 CreateDefaultSearchContextAndRequestSearchTerm(); 538 CreateDefaultSearchContextAndRequestSearchTerm();
539 EXPECT_EQ(kSomeSpecificBasePage, getBasePageUrlFromRequest()); 539 EXPECT_EQ(kSomeSpecificBasePage, getBasePageUrlFromRequest());
540 } 540 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698