Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: scripts/slave/recipe_modules/v8/gclient_config.py

Issue 2290463002: V8: Remove legacy svn deps variable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Fix file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/v8.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/gclient_config.py
diff --git a/scripts/slave/recipe_modules/v8/gclient_config.py b/scripts/slave/recipe_modules/v8/gclient_config.py
index fb3d6a903c578eeeb49097d9478279cf0cfd0c1f..7cf56813416439f24635e181feaa86bb3e08750a 100644
--- a/scripts/slave/recipe_modules/v8/gclient_config.py
+++ b/scripts/slave/recipe_modules/v8/gclient_config.py
@@ -7,19 +7,11 @@ CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
from recipe_engine.config import BadConf
-# TODO(machenbach): Remove this.
-def ChromiumSvnTrunkURL(c, *pieces):
- BASES = ('https://src.chromium.org/svn/trunk',
- 'svn://svn-mirror.golo.chromium.org/chrome/trunk')
- return '/'.join((BASES[c.USE_MIRROR],) + pieces)
-
-
@CONFIG_CTX()
def v8(c):
soln = c.solutions.add()
soln.name = 'v8'
soln.url = 'https://chromium.googlesource.com/v8/v8'
- soln.custom_vars = {'chromium_trunk': ChromiumSvnTrunkURL(c)}
c.got_revision_mapping['v8'] = 'got_revision'
# Needed to get the testers to properly sync the right revision.
# TODO(infra): Upload full buildspecs for every build to isolate and then use
« no previous file with comments | « no previous file | scripts/slave/recipes/run_presubmit.expected/v8.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698