|
|
Chromium Code Reviews
DescriptionRemove obselete entries from tools/gritsettings/resource_ids
Committed: https://crrev.com/db0550a37ec4b8e3170233671d864169ec655464
Cr-Commit-Position: refs/heads/master@{#415111}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
thestig@chromium.org changed reviewers: + sky@chromium.org, vitalybuka@chromium.org
sky: ash vitalybuka: cloud_print - if someone wants to try to build these targets again, they can set up their own resource_ids that does not conflict with the rest of Chromium, right?
On 2016/08/29 20:37:16, Lei Zhang wrote: > sky: ash > vitalybuka: cloud_print - if someone wants to try to build these targets again, > they can set up their own resource_ids that does not conflict with the rest of > Chromium, right? not sure what are you asking. What is the plan? Are we going to return CP code back into chromium or move somewhere outside?
On 2016/08/29 20:44:25, Vitaly Buka corp wrote: > On 2016/08/29 20:37:16, Lei Zhang wrote: > > sky: ash > > vitalybuka: cloud_print - if someone wants to try to build these targets > again, > > they can set up their own resource_ids that does not conflict with the rest of > > Chromium, right? > > not sure what are you asking. > What is the plan? Are we going to return CP code back into chromium or move > somewhere outside? I don't know where the CP code has been moved to. The copy I'm working with is just the deleted copy that has been reverted. As is, the .grd files references here do not exist, so shouldn't they be removed? If we put the CP code back, then we put back the .grd references here too.
On 2016/08/29 20:52:24, Lei Zhang wrote: > On 2016/08/29 20:44:25, Vitaly Buka corp wrote: > > On 2016/08/29 20:37:16, Lei Zhang wrote: > > > sky: ash > > > vitalybuka: cloud_print - if someone wants to try to build these targets > > again, > > > they can set up their own resource_ids that does not conflict with the rest > of > > > Chromium, right? > > > > not sure what are you asking. > > What is the plan? Are we going to return CP code back into chromium or move > > somewhere outside? > > I don't know where the CP code has been moved to. The copy I'm working with is > just the deleted copy that has been reverted. > > As is, the .grd files references here do not exist, so shouldn't they be > removed? If we put the CP code back, then we put back the .grd references here > too. I see, I thought decision was already made. LGTM
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Removal of ash/mus LGTM - thanks for cleaning up!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove obselete entries from tools/gritsettings/resource_ids ========== to ========== Remove obselete entries from tools/gritsettings/resource_ids Committed: https://crrev.com/db0550a37ec4b8e3170233671d864169ec655464 Cr-Commit-Position: refs/heads/master@{#415111} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/db0550a37ec4b8e3170233671d864169ec655464 Cr-Commit-Position: refs/heads/master@{#415111} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
