Source/web/tests/data/find_in_generated_frame.html - Issue 229043004: Fixed crash in WebFrameImpl::resetMatchCount function.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/find_in_generated_frame.html

Issue 229043004: Fixed crash in WebFrameImpl::resetMatchCount function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 onload = function() {

	6 // See http://code.google.com/p/chromium/issues/detail?id=359983 for details.

	7 var expressions = [

	8 " svgElem1 = document.createElementNS('http://www.w3.org/2000/svg', 'svg');" ,
	yosin_UTC9 2014/05/19 05:26:22 super-nit: It is better to use function closure ra super-nit: It is better to use function closure rather thane eval; - for coloring in editor - syntax check during loading var expression = [ function() { svgElem1 = ... }, function() { ... }, ... ]; Andrey Kraynov 2014/05/20 21:34:46 I tried to stick to the original, but I agree with Show quoted text On 2014/05/19 05:26:22, yosi wrote: > super-nit: It is better to use function closure rather thane eval; I tried to stick to the original, but I agree with you. Done.
	9 " svgElem2 = document.createElementNS('http://www.w3.org/2000/svg', 'svg');" ,

	10 " titleElem = document.createElementNS('http://www.w3.org/2000/svg', 'title' );",

	11 " generatedFrame = document.createElement('iframe');" +

	12 " if (!svgElem1.parentNode) {" +

	13 " document.body.appendChild(svgElem1);" +

	14 " }" +

	15 " svgElem1.parentNode.insertBefore(generatedFrame, svgElem1);"

	16 ];

	17

	18 function evalExpressions() {

	19 while (expressions.length > 0) {

	20 var expression = expressions.shift();

	21 eval(expression);

	22 }

	23 }

	24

	25 setTimeout(evalExpressions, 0);

	26 }

	27 </script>

	28 </head>

	29 <body>

	30 test

	31 </body>

	32 </html>

OLD	NEW

« Source/web/tests/WebFrameTest.cpp ('K') | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »