Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2290423002: Set 'packageResolverProvider' for ContextBuilder in DAS. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set 'packageResolverProvider' for ContextBuilder in DAS. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1c6d3472a66a0a2dcc66db6e971cea56a2e9bb34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-08-30 17:38:51 UTC) #1
Brian Wilkerson
lgtm, thanks!
4 years, 3 months ago (2016-08-30 17:52:32 UTC) #2
scheglov
4 years, 3 months ago (2016-08-30 17:56:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c6d3472a66a0a2dcc66db6e971cea56a2e9bb34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698