Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 22904002: When switching processes during redirects, update the cookie policy (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
Reviewers:
James Simonsen
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

When switching processes during redirects, update the cookie policy When we don't switch the process, the renderer takes care of updating the policy. However, when we switch the process, the redirect is handled in the browser, and we need to update the policy there. BUG=262860 R=simonjam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217113

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -8 lines) Patch
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 3 chunks +38 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/browser/loader/transfer_navigation_resource_throttle.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/shell.cc View 1 1 chunk +16 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 3 chunks +12 lines, -0 lines 0 comments Download
A content/test/data/set_cookie.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/set_cookie.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-12 18:05:22 UTC) #1
James Simonsen
lgtm
7 years, 4 months ago (2013-08-12 19:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/22904002/7001
7 years, 4 months ago (2013-08-12 19:45:27 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 23:24:05 UTC) #4
Message was sent while issue was closed.
Change committed as 217113

Powered by Google App Engine
This is Rietveld 408576698