Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2290393002: Remove src/tools/trace (Closed)

Created:
4 years, 3 months ago by eakuefner
Modified:
4 years, 3 months ago
Reviewers:
sullivan, nduca, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove src/tools/trace This directory has not been touched since 2008, appears to be from the very early history of tracing, and contains only some very primitive trace examples. The frontend tracing code lives in Catapult, so let's remove this dir. Committed: https://crrev.com/a866c91ab6f668c4ba073a1965dc940a14327376 Cr-Commit-Position: refs/heads/master@{#415360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1337 lines) Patch
D tools/trace/trace.html View 1 chunk +0 lines, -287 lines 0 comments Download
D tools/trace/trace_data.js View 1 chunk +0 lines, -1050 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
eakuefner
+dpranke for tools/ OWNERS :)
4 years, 3 months ago (2016-08-30 16:54:48 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-30 16:55:07 UTC) #4
sullivan
lgtm
4 years, 3 months ago (2016-08-30 17:20:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290393002/1
4 years, 3 months ago (2016-08-30 17:23:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 18:23:15 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:24:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a866c91ab6f668c4ba073a1965dc940a14327376
Cr-Commit-Position: refs/heads/master@{#415360}

Powered by Google App Engine
This is Rietveld 408576698