Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2290373003: Move error checking from scope creation to error reporter (take 2) (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move error checking from scope creation to error reporter (take 2) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3e58ee5799d91c52d2c98ce8fb42b223f0efbaaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -23 lines) Patch
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 9 chunks +256 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-08-30 18:13:47 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-08-30 18:20:05 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-08-30 18:22:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e58ee5799d91c52d2c98ce8fb42b223f0efbaaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698