Adding perf test isolate and gn build target for swarming the benchmarks.

Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop:

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253
Committed: https://crrev.com/d158d9585e170f34e2157ec853084acf06e0048d
Cr-Commit-Position: refs/heads/master@{#416255}

[eyaich1, 2016-08-30 16:38:21]

eyaich@chromium.org changed reviewers:
+ dtu@chromium.org

[eyaich1, 2016-08-30 16:42:21]

Description was changed from

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

BUG=chromium:633253
==========

to

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop: 

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253
==========

[dtu, 2016-08-30 18:19:00]

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:1718: group("telemetry_perf_tests") {
I think I prefer telemetry_benchmarks?
Our nomenclature is super confusing between run_tests and telemetry_perf_tests
and telemetry_perf_unittests.

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:1725: # For isolate contract.
Sorry, I don't understand.

https://codereview.chromium.org/2290373002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2290373002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:513: 'Win Builder':
'gn_official_goma_minimal_symbols_x86',
There's no such builder. chromium.perf.fyi is using the chromium.perf builder.

[dtu, 2016-08-30 18:19:13]

lgtm

[eyaich1, 2016-08-31 14:01:54]

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:1718: group("telemetry_perf_tests") {
On 2016/08/30 18:19:00, dtu wrote:
> I think I prefer telemetry_benchmarks?
> Our nomenclature is super confusing between run_tests and telemetry_perf_tests
> and telemetry_perf_unittests.

telemetry_benchmarks may be misleading given that other non-telemetry based perf
tests will be run on these swarmed bots.  I would like to keep this target
consistently named here and in the gn_isolate_map and how we reference them in
the json files.  Changing this only here might get confusing on how it is
referenced and I don't want to change this everywhere given it will eventually
be more than just the benchmarks.  

I think telemetry_perf_tests is consistent in naming, ie unittests are reserved
for tests that test the framework.  I think the run_tests and other scripts
should be updated to match this naming convention.

https://codereview.chromium.org/2290373002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:1725: # For isolate contract.
On 2016/08/30 18:19:00, dtu wrote:
> Sorry, I don't understand.

These are dependencies needed for the script that is actually run in the isolate
to execute.  I updated the comment.

https://codereview.chromium.org/2290373002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2290373002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:513: 'Win Builder':
'gn_official_goma_minimal_symbols_x86',
On 2016/08/30 18:19:00, dtu wrote:
> There's no such builder. chromium.perf.fyi is using the chromium.perf builder.

Done.

[dtu, 2016-09-01 05:18:38]

https://codereview.chromium.org/2290373002/diff/20001/testing/scripts/run_tel...
File testing/scripts/run_telemetry_benchmark_as_googletest.py (right):

https://codereview.chromium.org/2290373002/diff/20001/testing/scripts/run_tel...
testing/scripts/run_telemetry_benchmark_as_googletest.py:43: logging.info("1: IN
THE SCRIPT")
Are these intentional?

[eyaich1, 2016-09-01 14:19:35]

https://codereview.chromium.org/2290373002/diff/20001/testing/scripts/run_tel...
File testing/scripts/run_telemetry_benchmark_as_googletest.py (right):

https://codereview.chromium.org/2290373002/diff/20001/testing/scripts/run_tel...
testing/scripts/run_telemetry_benchmark_as_googletest.py:43: logging.info("1: IN
THE SCRIPT")
On 2016/09/01 05:18:38, dtu wrote:
> Are these intentional?

lol definitely not.  this file sholdn't be included at all, was just for
debugging one of the tasks.  Removed.

[eyaich1, 2016-09-01 14:21:03]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-09-01 14:21:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/2290373002/#ps60001
(title: "fixing syntac")

[commit-bot: I haz the power, 2016-09-01 14:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 14:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 14:27:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eyaich1, 2016-09-01 14:30:05]

eyaich@chromium.org changed reviewers:
+ dpranke@chromium.org

[eyaich1, 2016-09-01 14:30:41]

On 2016/09/01 14:27:25, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

+ dpranke@ for directory ownership approval

[Dirk Pranke, 2016-09-01 19:28:22]

lgtm

[eyaich1, 2016-09-02 12:37:40]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-09-02 12:37:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 13:24:01]

Description was changed from

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop: 

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253
==========

to

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop: 

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253
==========

[commit-bot: I haz the power, 2016-09-02 13:24:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 13:26:11]

Description was changed from

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop: 

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253
==========

to

==========
Adding perf test isolate and gn build target for swarming the benchmarks.

Dependencies are correct, successful triggered task on 4 core laptop:

https://chromium-swarm.appspot.com/user/task/30f4a1312196bc10

BUG=chromium:633253

Committed: https://crrev.com/d158d9585e170f34e2157ec853084acf06e0048d
Cr-Commit-Position: refs/heads/master@{#416255}
==========

[commit-bot: I haz the power, 2016-09-02 13:26:12]

Patchset 4 (id:??) landed as
https://crrev.com/d158d9585e170f34e2157ec853084acf06e0048d
Cr-Commit-Position: refs/heads/master@{#416255}