Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2290363002: services/ui: Set the gpu_channel_ to new added displays. (Closed)

Created:
4 years, 3 months ago by Peng
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Set the gpu_channel_ to new added displays. On minnie, the Display initializing is slow, so the display is ready after GpuService. So only notifying initialized displays when the GPU channel is established is not sufficient. We need also set the GPU channel to every display when it is ready. BUG=None Committed: https://crrev.com/b3ab255e9b5fe0580d7647a72cc3c4ad07a1178a Cr-Commit-Position: refs/heads/master@{#415332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M services/ui/ws/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Peng
Hi Scott, PTAL. Thanks.
4 years, 3 months ago (2016-08-30 15:46:11 UTC) #4
sky
LGTM
4 years, 3 months ago (2016-08-30 16:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290363002/1
4 years, 3 months ago (2016-08-30 17:11:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:15:59 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:18:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3ab255e9b5fe0580d7647a72cc3c4ad07a1178a
Cr-Commit-Position: refs/heads/master@{#415332}

Powered by Google App Engine
This is Rietveld 408576698