Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

Issue 2290353002: Fix crash when scrolling in a remote process frame (Closed)
Patch Set: Added TODOs Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TopDocumentRootScrollerController_h 5 #ifndef TopDocumentRootScrollerController_h
6 #define TopDocumentRootScrollerController_h 6 #define TopDocumentRootScrollerController_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/page/scrolling/RootScrollerController.h" 9 #include "core/page/scrolling/RootScrollerController.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class Document; 14 class Document;
15 class Element; 15 class Element;
16 class GraphicsLayer; 16 class GraphicsLayer;
17 class ScrollStateCallback; 17 class ScrollStateCallback;
18 class ViewportScrollCallback; 18 class ViewportScrollCallback;
19 19
20 // The RootScrollerController used to manage the root scroller for the top 20 // The RootScrollerController used to manage the root scroller for the top
21 // level Document on a page. In addition to the regular RootScroller duties, 21 // level Document on a page. In addition to the regular RootScroller duties,
22 // such as keeping track of which Element is set as root scroller and which is 22 // such as keeping track of which Element is set as root scroller and which is
23 // the effective root scroller, this class is also manages the "global" root 23 // the effective root scroller, this class is also manages the "global" root
24 // scroller. That is, given all the iframes on a page and their individual root 24 // scroller. That is, given all the iframes on a page and their individual root
25 // scrollers, this class will determine which ultimate Element should be used 25 // scrollers, this class will determine which ultimate Element should be used
26 // as the root scroller and ensures that Element is used to scroll top controls 26 // as the root scroller and ensures that Element is used to scroll top controls
27 // and provide overscroll effects. 27 // and provide overscroll effects.
28 // TODO(bokan): This class is currently OOPIF unaware. It should be broken into 28 // TODO(bokan): This class is currently OOPIF unaware. It should be broken into
29 // a standalone class and placed on a Page level object. crbug.com/505516 29 // a standalone class and placed on a Page level object. crbug.com/642378.
30 class CORE_EXPORT TopDocumentRootScrollerController 30 class CORE_EXPORT TopDocumentRootScrollerController
31 : public RootScrollerController { 31 : public RootScrollerController {
32 public: 32 public:
33 static TopDocumentRootScrollerController* create(Document&); 33 static TopDocumentRootScrollerController* create(Document&);
34 34
35 DECLARE_VIRTUAL_TRACE(); 35 DECLARE_VIRTUAL_TRACE();
36 36
37 // This class needs to be informed of changes to compositing so that it can 37 // This class needs to be informed of changes to compositing so that it can
38 // update the compositor when the effective root scroller changes. 38 // update the compositor when the effective root scroller changes.
39 void didUpdateCompositing() override; 39 void didUpdateCompositing() override;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 Member<ViewportScrollCallback> m_viewportApplyScroll; 76 Member<ViewportScrollCallback> m_viewportApplyScroll;
77 77
78 // The page level root scroller. i.e. The actual element for which scrolling 78 // The page level root scroller. i.e. The actual element for which scrolling
79 // should move top controls and produce overscroll glow. 79 // should move top controls and produce overscroll glow.
80 WeakMember<Element> m_globalRootScroller; 80 WeakMember<Element> m_globalRootScroller;
81 }; 81 };
82 82
83 } // namespace blink 83 } // namespace blink
84 84
85 #endif // RootScrollerController_h 85 #endif // RootScrollerController_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698