Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2290333002: [heap] Simplify heuristics for incremental step size. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Simplify heuristics for incremental step size. This patch removes the code for speeding up marking. Now the step size depends on allocated bytes and invoked write barriers. We also ensure that the step size is large enough to justify the overhead of interrupting the generated code. BUG=chromium:616434 LOG=NO Committed: https://crrev.com/71a793e4b1026e69d4009df0a419fe260fe1a235 Cr-Commit-Position: refs/heads/master@{#39067}

Patch Set 1 : x #

Patch Set 2 : clean-up #

Patch Set 3 : more cleanup #

Patch Set 4 : fix flags #

Patch Set 5 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -155 lines) Patch
M src/heap/heap.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 4 4 chunks +6 lines, -20 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 8 chunks +17 lines, -124 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
ulan
ptal
4 years, 3 months ago (2016-08-31 17:04:50 UTC) #11
Michael Lippautz
lgtm, fingers crossed that it doesn't regress :)
4 years, 3 months ago (2016-08-31 17:10:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290333002/180001
4 years, 3 months ago (2016-09-01 08:05:25 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 3 months ago (2016-09-01 08:32:02 UTC) #17
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/71a793e4b1026e69d4009df0a419fe260fe1a235 Cr-Commit-Position: refs/heads/master@{#39067}
4 years, 3 months ago (2016-09-01 08:32:42 UTC) #19
ulan
4 years, 3 months ago (2016-09-01 17:28:30 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:180001) has been created in
https://codereview.chromium.org/2304613002/ by ulan@chromium.org.

The reason for reverting is: Regressed GC times in v8.infinite_scroll_tbmv2
benchmarks..

Powered by Google App Engine
This is Rietveld 408576698