Issue 229033003: PPAPI: Update pp_var.h documentation for Resource vars.

Issue 229033003: PPAPI: Update pp_var.h documentation for Resource vars. (Closed)

Created:
6 years, 8 months ago by dmichael (off chromium)

Modified:
6 years, 8 months ago

Reviewers:
raymes

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI: Update pp_var.h documentation for Resource vars. BUG=361215 R=raymes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263135

Patch Set 1 #

Patch Set 2 : some doxygen tweaks #

Total comments: 2

Patch Set 3 : consistency fixes per review #

Patch Set 4 : consistency fixes per review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -35 lines)			Patch
M	ppapi/api/pp_var.idl	View	1 2	4 chunks	+21 lines, -10 lines	0 comments	Download
M	ppapi/api/ppb_var.idl	View	1 2	4 chunks	+13 lines, -7 lines	0 comments	Download
M	ppapi/c/pp_var.h	View	1 2	3 chunks	+22 lines, -11 lines	0 comments	Download
M	ppapi/c/ppb_var.h	View	1 2	4 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

raymes

lgtm with nits Thanks for this! https://codereview.chromium.org/229033003/diff/20001/ppapi/api/pp_var.idl File ppapi/api/pp_var.idl (right): https://codereview.chromium.org/229033003/diff/20001/ppapi/api/pp_var.idl#newcode94 ppapi/api/pp_var.idl:94: * properly to ...

6 years, 8 months ago (2014-04-09 00:16:17 UTC) #2

dmichael (off chromium)

The CQ bit was checked by dmichael@chromium.org

6 years, 8 months ago (2014-04-10 20:56:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/229033003/60001

6 years, 8 months ago (2014-04-10 20:57:01 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-10 21:27:46 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg

6 years, 8 months ago (2014-04-10 21:27:46 UTC) #6

dmichael (off chromium)

The CQ bit was checked by dmichael@chromium.org

6 years, 8 months ago (2014-04-10 21:39:36 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/229033003/60001

6 years, 8 months ago (2014-04-10 21:41:20 UTC) #8

Message was sent while issue was closed.

Change committed as 263135

Expand Messages | Collapse Messages