DevTools: use eventListener arrays to avoid memory leaks in dispose methods

third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.TargetManager} targetManager
  * @param {!WebInspector.Workspace} workspace
  * @param {!WebInspector.FileSystemWorkspaceBinding} fileSystemWorkspaceBinding
  * @param {!WebInspector.FileSystemMapping} fileSystemMapping
  */
 WebInspector.NetworkMapping = function(targetManager, workspace, fileSystemWorkspaceBinding, fileSystemMapping)
 {
     this._targetManager = targetManager;
     this._workspace = workspace;
     this._fileSystemWorkspaceBinding = fileSystemWorkspaceBinding;
     this._fileSystemMapping = fileSystemMapping;
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.RevealSourceLine, this._revealSourceLine, this);
 
     // For now, following block is here primarily for testing since in the real life, network manager is created early enough to capture those events.
     var fileSystemManager = fileSystemWorkspaceBinding.fileSystemManager();
     for (var path of fileSystemManager.fileSystemPaths()) {
         var fileSystem = fileSystemManager.fileSystem(path);
         this._fileSystemAdded(new WebInspector.Event(fileSystemManager, WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, fileSystem));
     }
     if (fileSystemManager.fileSystemsLoaded())
         this._fileSystemsLoaded();
 
-    fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this);
-    fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this);
-    fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemsLoaded, this._fileSystemsLoaded, this);
-
-    this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded, this._fileSystemMappingChanged, this);
-    this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingRemoved, this._fileSystemMappingChanged, this);
+    this._eventListeners = [
+        fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this),
+        fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this),
+        fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemsLoaded, this._fileSystemsLoaded, this),
+        this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded, this._fileSystemMappingChanged, this),
+        this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingRemoved, this._fileSystemMappingChanged, this)
+    ];
 }
 
 WebInspector.NetworkMapping.prototype = {
     /**
      * @param {!WebInspector.Event} event
      */
     _fileSystemAdded: function(event)
     {
         this._addingFileSystem = true;
         var fileSystem = /** @type {!WebInspector.IsolatedFileSystem} */ (event.data);
@@ skipping 193 matching lines @@
 
     _fileSystemMappingChanged: function()
     {
         if (!this._fileSystemsReady || this._addingFileSystem)
             return;
         this._targetManager.suspendAndResumeAllTargets();
     },
 
     dispose: function()
     {
-        this._fileSystemWorkspaceBinding.fileSystemManager().removeEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this);
-        this._fileSystemWorkspaceBinding.fileSystemManager().removeEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this);
-        this._fileSystemMapping.removeEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded, this._fileSystemMappingChanged, this);
-        this._fileSystemMapping.removeEventListener(WebInspector.FileSystemMapping.Events.FileMappingRemoved, this._fileSystemMappingChanged, this);
+        WebInspector.EventTarget.removeEventListeners(this._eventListeners);
     }
 }
 
 /**
  * @type {!WebInspector.NetworkMapping}
  */
 WebInspector.networkMapping;