Issue 22903042: The archive checker should accept empty archives

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22903042: The archive checker should accept empty archives (Closed)

Created:
7 years, 4 months ago by Petr Hosek

Modified:
7 years, 4 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

The archive checker should accept empty archives This change modifies the archive checker in the PNaCl toolchain build to accept empty archives which are used in some modules for backwards compatibility. BUG= none TESTS= none R=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12053

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	pnacl/build.sh	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Derek Schuff

lgtm LGTM, but change the commit message to reflect that it's the archive checker in ...

7 years, 4 months ago (2013-08-23 20:26:21 UTC) #2

Petr Hosek

7 years, 4 months ago (2013-08-23 21:12:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12053 (presubmit successful).