Issue 22903027: Prefill allocated objects with one word fillers if we do not use allocation folding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22903027: Prefill allocated objects with one word fillers if we do not use allocation folding. (Closed)

Created:
7 years, 4 months ago by Hannes Payer (out of office)

Modified:
7 years, 3 months ago

Reviewers:
titzer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prefill allocated objects with one word fillers if we do not use allocation folding. BUG= R=mstarzinger@chromium.org, titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16357

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/hydrogen-instructions.h	View	1 2	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/22903027/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/22903027/diff/1/src/hydrogen-instructions.h#newcode5126 src/hydrogen-instructions.h:5126: // not use allocation folding. This comment would ...

7 years, 4 months ago (2013-08-22 12:32:56 UTC) #2

Michael Starzinger

LGTM. https://codereview.chromium.org/22903027/diff/6001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/22903027/diff/6001/src/hydrogen-instructions.h#newcode5128 src/hydrogen-instructions.h:5128: // allocations may leave such objects behind an ...

7 years, 4 months ago (2013-08-22 13:17:30 UTC) #3

Hannes Payer (out of office)

7 years, 3 months ago (2013-08-27 12:04:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r16357 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22903027: Prefill allocated objects with one word fillers if we do not use allocation folding. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages