Issue 22903023: Simplify ContentWatcher by calling querySelector directly instead of through JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22903023: Simplify ContentWatcher by calling querySelector directly instead of through JS. (Closed)

Created:
7 years, 4 months ago by Jeffrey Yasskin

Modified:
7 years, 4 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify ContentWatcher by calling querySelector directly instead of through JS. BUG=172011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219110

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -53 lines)			Patch
	M	chrome/renderer/extensions/content_watcher.cc	View		2 chunks	+9 lines, -38 lines	0 comments	Download
	M	chrome/renderer/resources/extensions/content_watcher.js	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jeffrey Yasskin

On 2013/08/22 17:29:47, Yoyo Zhou wrote: > Is this covered by tests? https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc covers it ...

7 years, 4 months ago (2013-08-22 18:10:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/22903023/1

7 years, 4 months ago (2013-08-22 18:24:24 UTC) #4

Message was sent while issue was closed.

Change committed as 219110

Expand Messages | Collapse Messages