chrome/browser/extensions/extension_host.cc - Issue 22903022: Limit constrained windows to the size of the parent view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.cc

Issue 22903022: Limit constrained windows to the size of the parent view. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: No initializer Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_host.cc

diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc

index bd439288bb516a74e933d5a50b9d3a7bd87ca7eb..286be86e176498b109d8444058ed9ce007a2c28d 100644

--- a/chrome/browser/extensions/extension_host.cc

+++ b/chrome/browser/extensions/extension_host.cc

@@ -311,6 +311,12 @@ gfx::Point ExtensionHost::GetDialogPosition(const gfx::Size& size) {

std::max(0, (bounds.height() - size.height()) / 2));

}

+gfx::Size ExtensionHost::GetMaximumDialogSize() {

+ if (!GetVisibleWebContents())

+ return gfx::Size();

+ return GetVisibleWebContents()->GetView()->GetViewBounds().size();

void ExtensionHost::AddObserver(

web_modal::WebContentsModalDialogHostObserver* observer) {

}