[android] Adds constants.GetOutDirectory() and converts test scripts to use it.

build/android/pylib/constants.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Defines a set of constants shared by test runners and other scripts."""
 
 import os
 import subprocess
 import sys
 
@@ skipping 76 matching lines @@
   try:
     return os.environ['BUILDTYPE']
   except KeyError:
     raise Exception('The BUILDTYPE environment variable has not been set')
 
 
 def SetBuildType(build_type):
   os.environ['BUILDTYPE'] = build_type
 
 
+def GetBuildDirectory(build_type=None):

[bulach, 2013/09/02 09:11:18]

hmm... "BuildDirectory" is a bit ambiguous, there's build/ from the buildbot
repository, then $CHROMIUM_SRC/build (where this script lives), and yet it
returns "out/BUILDTYPE" :)

how about keeping as GetOutDirectory() and something like this:
"""Returns the out directory where the output binaries are built."""

wdyt?

[craigdh, 2013/09/03 18:36:09]

Done.

+  """Returns the build directory.
+
+  Args:
+    build_type: Build type, generally 'Debug' or 'Release'. Defaults to the
+      globally set build type environment variable BUILDTYPE.
+  """
+  return os.path.abspath(os.path.join(
+      DIR_SOURCE_ROOT, os.environ.get('CHROMIUM_OUT_DIR', 'out'),

[frankf, 2013/08/27 00:44:57]

who sets this?

[craigdh, 2013/08/27 16:57:17]

I'm not sure who overrides the out directory (took this from the existing code),
but if it's not set it gets defaulted to 'out' so it's not really an issue.

[bulach, 2013/09/02 09:11:18]

yeah, the idea behind this is that we'd eventually have envsetup.sh, (or maybe
some other wrapper script) setting this environment variable to something else,
say, "out_android", and then we'd be able to build both android and linux
side-by-side (not the same shell, just the same repository / checkout)...

we're not there yet, but iancottrel@ is working on some parts of it..

+      GetBuildType() if build_type is None else build_type))
+
+
 def _GetADBPath():
   if os.environ.get('ANDROID_SDK_ROOT'):
     return 'adb'
   # If envsetup.sh hasn't been sourced and there's no adb in the path,
   # set it here.
   try:
     with file(os.devnull, 'w') as devnull:
       subprocess.call(['adb', 'version'], stdout=devnull, stderr=devnull)
     return 'adb'
   except OSError:
     print >> sys.stderr, 'No adb found in $PATH, fallback to checked in binary.'
     return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb')
 
 
 ADB_PATH = _GetADBPath()
 
 # Exit codes
 ERROR_EXIT_CODE = 1
 WARNING_EXIT_CODE = 88