[wasm] Validate the index of set local in AnalyzeLoopAssignment

[wasm] Validate the index of set local in AnalyzeLoopAssignment

BUG=chromium:642867
R=titzer@chromium.org
TEST=loop-assignment-analysis-unittest.cc:regress_642867

Committed: https://crrev.com/79e685e277298102c0386c8da0b5c2e8316baca2
Cr-Commit-Position: refs/heads/master@{#39089}

[ahaas, 2016-09-01 13:10:44]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 13:10:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-09-01 13:12:44]

https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1853: if (Validate(pc_, operand)) {
I think if you just remove the static_cast to int, this will work. That was the
intention of the check, anyway.

[titzer, 2016-09-01 13:14:11]

On 2016/09/01 13:12:44, titzer wrote:
> https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:1853: if (Validate(pc_, operand)) {
> I think if you just remove the static_cast to int, this will work. That was
the
> intention of the check, anyway.

Or static_cast<uint32_t> the length of the BitVector.
Chalk this bug up to C++'s stupid signed/unsigned comparisons.

[commit-bot: I haz the power, 2016-09-01 13:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 13:33:08]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-09-01 13:44:49]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 13:44:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-09-01 13:53:15]

https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1853: if (Validate(pc_, operand)) {
On 2016/09/01 at 13:12:44, titzer wrote:
> I think if you just remove the static_cast to int, this will work. That was
the intention of the check, anyway.

Done. I think that calling Validate() would have actually been an error because
Validate() causes an error state.

[titzer, 2016-09-01 13:54:17]

On 2016/09/01 13:53:15, ahaas wrote:
> https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/2290233008/diff/1/src/wasm/ast-decoder.cc#new...
> src/wasm/ast-decoder.cc:1853: if (Validate(pc_, operand)) {
> On 2016/09/01 at 13:12:44, titzer wrote:
> > I think if you just remove the static_cast to int, this will work. That was
> the intention of the check, anyway.
> 
> Done. I think that calling Validate() would have actually been an error
because
> Validate() causes an error state.

Right, it could report an error from later in the instruction stream than what
would normally happen, since loop assignment analysis can "skip ahead".

lgtm

[ahaas, 2016-09-01 13:54:56]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-09-01 13:54:59]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-09-01 13:55:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 14:05:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 14:06:00]

Description was changed from

==========
[wasm] Validate the index of set local in AnalyzeLoopAssignment

BUG=chromium:642867
R=titzer@chromium.org
TEST=loop-assignment-analysis-unittest.cc:regress_642867
==========

to

==========
[wasm] Validate the index of set local in AnalyzeLoopAssignment

BUG=chromium:642867
R=titzer@chromium.org
TEST=loop-assignment-analysis-unittest.cc:regress_642867

Committed: https://crrev.com/79e685e277298102c0386c8da0b5c2e8316baca2
Cr-Commit-Position: refs/heads/master@{#39089}
==========

[commit-bot: I haz the power, 2016-09-01 14:06:01]

Patchset 2 (id:??) landed as
https://crrev.com/79e685e277298102c0386c8da0b5c2e8316baca2
Cr-Commit-Position: refs/heads/master@{#39089}