third_party/WebKit/Source/web/PopupMenuImpl.cpp - Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)

Patch Set: add client to WebSharedWorkerImpl Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp

diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

index 39d7b80a7bac4561f131de5fbb5c7e609133d4b5..15cc1b3b8d1b96aa6ca4f6d6472d3255ed4f81ca 100644

--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp

+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp

@@ -276,7 +276,7 @@ void PopupMenuImpl::writeDocument(SharedBuffer* data)

addProperty("anchorRectInScreen", anchorRectInScreen, data);

float zoom = zoomFactor();

- float scaleFactor = m_chromeClient->windowToViewportScalar(1.f);

+ float scaleFactor = m_chromeClient->windowToViewportScalar(*ownerElement.document().frame()->view(), 1.f);

addProperty("zoomFactor", zoom / scaleFactor, data);

bool isRTL = !ownerStyle->isLeftToRightDirection();

addProperty("isRTL", isRTL, data);