third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp - Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)

Patch Set: add client to WebSharedWorkerImpl Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

index b69bf78748a0bc62f544bc00393323ff0a2b6cdc..4c55812d0f7061680bf7722459aa2fd9a45eb945 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

@@ -242,7 +242,7 @@ InspectorHighlight::InspectorHighlight(Node* node, const InspectorHighlightConfi

{

FrameView* frameView = node->document().view();

if (frameView)

- m_scale = 1.f / frameView->getHostWindow()->windowToViewportScalar(1.f);

+ m_scale = 1.f / frameView->getHostWindow()->windowToViewportScalar(*frameView, 1.f);

appendPathsForShapeOutside(node, highlightConfig);

appendNodeHighlight(node, highlightConfig);

if (appendElementInfo && node->isElementNode())