Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 133eb46f16fb87fda78fcfc3e1491a31cf985f06..f4672bc204566302776e0ac963a1bbb2945d1df0 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -8110,6 +8110,8 @@ TEST_P(ParameterizedWebFrameTest, RemoteToLocalSwapOnMainFrameInitializesCoreFra
// Do a remote-to-local swap of the top frame.
FrameTestHelpers::TestWebFrameClient localClient;
WebLocalFrame* localRoot = WebLocalFrame::createProvisional(&localClient, remoteRoot, WebSandboxFlags::None);
+ FrameTestHelpers::TestWebWidgetClient webWidgetClient;
+ WebFrameWidget::create(&webWidgetClient, localRoot);
dcheng 2016/09/02 08:57:39 Would it be better to just make FrameTestHelpers d
lfg 2016/09/02 17:36:38 In this case I didn't think it was worth the effor
remoteRoot->swap(localRoot);
// Load a page with a child frame in the new root to make sure this doesn't

Powered by Google App Engine
This is Rietveld 408576698