Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 933922495a0985c92a962d90a435c3cae97b7586..384389050e71991e401317810139fb078d0b01c6 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2022,14 +2022,6 @@ void RenderViewImpl::closeWidgetSoon() {
RenderWidget::closeWidgetSoon();
}
-void RenderViewImpl::convertViewportToWindow(blink::WebRect* rect) {
- RenderWidget::convertViewportToWindow(rect);
-}
-
-void RenderViewImpl::convertWindowToViewport(blink::WebFloatRect* rect) {
- RenderWidget::convertWindowToViewport(rect);
-}
-
void RenderViewImpl::didAutoResize(const blink::WebSize& newSize) {
RenderWidget::DidAutoResize(newSize);
}
@@ -2114,7 +2106,7 @@ const std::string& RenderViewImpl::GetAcceptLanguages() const {
}
void RenderViewImpl::ConvertViewportToWindowViaWidget(blink::WebRect* rect) {
dcheng 2016/09/02 08:57:39 These all need to move eventually as well, right?
lfg 2016/09/02 17:36:37 Yes, that's right. However, drag and drop depends
- convertViewportToWindow(rect);
+ GetWidget()->convertViewportToWindow(rect);
}
gfx::RectF RenderViewImpl::ElementBoundsInWindow(
@@ -2131,7 +2123,7 @@ bool RenderViewImpl::HasAddedInputHandler() const {
gfx::Point RenderViewImpl::ConvertWindowPointToViewport(
const gfx::Point& point) {
blink::WebFloatRect point_in_viewport(point.x(), point.y(), 0, 0);
- convertWindowToViewport(&point_in_viewport);
+ GetWidget()->convertWindowToViewport(&point_in_viewport);
return gfx::Point(point_in_viewport.x, point_in_viewport.y);
}

Powered by Google App Engine
This is Rietveld 408576698