Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 2290233004: currentlyscrollinglayer cleared in scrollAnimatedBegin. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/blink/input_handler_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 2ec8f709dc2add212eb5f63ffc57fd2fa8bf4ee9..53f3dadcb41549257b77eb201a68f3292e0df76a 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -2788,7 +2788,7 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollAnimatedBegin(
ScrollStateData scroll_state_data;
scroll_state_data.position_x = viewport_point.x();
scroll_state_data.position_y = viewport_point.y();
- scroll_state_data.is_in_inertial_phase = true;
+ scroll_state_data.is_in_inertial_phase = false;
ScrollState scroll_state(scroll_state_data);
// ScrollAnimated is used for animated wheel scrolls. We find the first layer
@@ -2801,7 +2801,11 @@ InputHandler::ScrollStatus LayerTreeHostImpl::ScrollAnimatedBegin(
ScrollStateData scroll_state_end_data;
scroll_state_end_data.is_ending = true;
ScrollState scroll_state_end(scroll_state_end_data);
+ // TODO(Sahel): Once the touchpad scroll latching for Non-mac devices is
+ // impelemented, the current scrolling layer should not get cleared after
tdresser 2016/08/31 13:10:05 implemented
sahel 2016/08/31 14:25:10 Done.
+ // each animation (crbug.com/526463).
ScrollEnd(&scroll_state_end);
+ ClearCurrentlyScrollingLayer();
ymalik 2016/08/31 14:01:55 I suspect that this is working correctly now becau
sahel 2016/08/31 14:25:09 It is working because of the call. The problem was
}
return scroll_status;
}
« no previous file with comments | « no previous file | ui/events/blink/input_handler_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698