Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/compiler/access-info.h

Issue 2290233002: [turbofan] Introduce MachineRepresentation to PropertyAccessInfo. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/access-info.h
diff --git a/src/compiler/access-info.h b/src/compiler/access-info.h
index 8c49a62c5029c321708fe9ed6da8f3de6732bb9c..d6fa8a98079509b58d10ee941d0a9b75a17866b5 100644
--- a/src/compiler/access-info.h
+++ b/src/compiler/access-info.h
@@ -8,6 +8,7 @@
#include <iosfwd>
#include "src/field-index.h"
+#include "src/machine-type.h"
#include "src/objects.h"
#include "src/zone-containers.h"
@@ -68,7 +69,8 @@ class PropertyAccessInfo final {
Handle<Object> constant,
MaybeHandle<JSObject> holder);
static PropertyAccessInfo DataField(
- MapList const& receiver_maps, FieldIndex field_index, Type* field_type,
+ MapList const& receiver_maps, FieldIndex field_index,
+ MachineRepresentation representation, Type* field_type,
MaybeHandle<JSObject> holder = MaybeHandle<JSObject>(),
MaybeHandle<Map> transition_map = MaybeHandle<Map>());
static PropertyAccessInfo AccessorConstant(MapList const& receiver_maps,
@@ -92,6 +94,7 @@ class PropertyAccessInfo final {
Handle<Object> constant() const { return constant_; }
FieldIndex field_index() const { return field_index_; }
Type* field_type() const { return field_type_; }
+ MachineRepresentation representation() const { return representation_; }
Benedikt Meurer 2016/08/30 17:14:49 Nit: Can you rename to field_representation?
mvstanton 2016/08/30 18:59:34 Done.
MapList const& receiver_maps() const { return receiver_maps_; }
private:
@@ -101,7 +104,8 @@ class PropertyAccessInfo final {
Handle<Object> constant, MapList const& receiver_maps);
PropertyAccessInfo(MaybeHandle<JSObject> holder,
MaybeHandle<Map> transition_map, FieldIndex field_index,
- Type* field_type, MapList const& receiver_maps);
+ MachineRepresentation representation, Type* field_type,
Benedikt Meurer 2016/08/30 17:14:49 Nit: Can you rename to field_representation?
mvstanton 2016/08/30 18:59:34 Done.
+ MapList const& receiver_maps);
Kind kind_;
MapList receiver_maps_;
@@ -109,6 +113,7 @@ class PropertyAccessInfo final {
MaybeHandle<Map> transition_map_;
MaybeHandle<JSObject> holder_;
FieldIndex field_index_;
+ MachineRepresentation representation_;
Benedikt Meurer 2016/08/30 17:14:49 Nit: Can you rename to field_representation_?
mvstanton 2016/08/30 18:59:34 Done.
Type* field_type_;
};

Powered by Google App Engine
This is Rietveld 408576698