Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2290223003: libfuzzer: add documentation recommending how to silence error logging (Closed)

Created:
4 years, 3 months ago by robert.bradford
Modified:
4 years, 3 months ago
Reviewers:
mmoroz, inferno
CC:
chromium-reviews, kcc2, aizatsky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libfuzzer: add documentation recommending how to silence error logging TEST=Using local md_browser.py check documentation formatting is correct. BUG=none Committed: https://crrev.com/160c5986b88cd140486c9ecfb4df3e739e334b02 Cr-Commit-Position: refs/heads/master@{#415330}

Patch Set 1 #

Total comments: 4

Patch Set 2 : adjust title; make clear this is for chromium logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M testing/libfuzzer/getting_started.md View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
robert.bradford
Not a technical solution to the problem but might work as an interim?
4 years, 3 months ago (2016-08-30 15:47:51 UTC) #2
mmoroz
https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md File testing/libfuzzer/getting_started.md (right): https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md#newcode111 testing/libfuzzer/getting_started.md:111: The best way to do that is to override ...
4 years, 3 months ago (2016-08-30 15:54:01 UTC) #3
inferno
lgtm with Max's comment addressed. We should probably mention about reducing writing to disk as ...
4 years, 3 months ago (2016-08-30 15:56:46 UTC) #4
inferno
Another comment. https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md File testing/libfuzzer/getting_started.md (right): https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md#newcode107 testing/libfuzzer/getting_started.md:107: ## Remove error message logging s/Remove/Disable noisy
4 years, 3 months ago (2016-08-30 15:57:39 UTC) #5
robert.bradford
mmoroz@ are you happy with this wording? https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md File testing/libfuzzer/getting_started.md (right): https://codereview.chromium.org/2290223003/diff/1/testing/libfuzzer/getting_started.md#newcode107 testing/libfuzzer/getting_started.md:107: ## Remove ...
4 years, 3 months ago (2016-08-30 16:16:51 UTC) #6
mmoroz
LGTM, Thanks Robert!
4 years, 3 months ago (2016-08-30 16:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290223003/20001
4 years, 3 months ago (2016-08-30 16:23:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 17:04:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:06:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/160c5986b88cd140486c9ecfb4df3e739e334b02
Cr-Commit-Position: refs/heads/master@{#415330}

Powered by Google App Engine
This is Rietveld 408576698