Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2290213002: [gn] Allow overriding sanitizer suppression files (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, ehmaldonado_chromium, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/6b6d4c12f4572b726fe9059f7e21194b278a6e95 Cr-Commit-Position: refs/heads/master@{#39009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Michael Achenbach
PTAL - optionally we can also use our own empty suppression files in the future...
4 years, 3 months ago (2016-08-30 11:47:42 UTC) #3
Michael Achenbach
This blocks rolling build: https://codereview.chromium.org/2289063002
4 years, 3 months ago (2016-08-30 11:48:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290213002/1
4 years, 3 months ago (2016-08-30 12:13:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 12:15:41 UTC) #13
vogelheim
lgtm
4 years, 3 months ago (2016-08-30 12:16:03 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 12:16:05 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b6d4c12f4572b726fe9059f7e21194b278a6e95
Cr-Commit-Position: refs/heads/master@{#39009}

Powered by Google App Engine
This is Rietveld 408576698