Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Michael Achenbach Modified:
4 years, 3 months ago Reviewers:
kjellander_chromium, jochen (gone - plz use gerrit), vogelheim CC:
v8-reviews_googlegroups.com, ehmaldonado_chromium, Dirk Pranke Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Allow overriding sanitizer suppression files
Port https://codereview.chromium.org/2267753002/
BUG=474921
TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org
Committed: https://crrev.com/6b6d4c12f4572b726fe9059f7e21194b278a6e95
Cr-Commit-Position: refs/heads/master@{#39009}
Patch Set 1 #
Created: 4 years, 3 months ago
Messages
Total messages: 16 (10 generated)
Description was changed from ========== [gn] Port overriding of sanitizer suppression files BUG= ========== to ========== [gn] Allow overriding sanitizer suppression files BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org
PTAL - optionally we can also use our own empty suppression files in the future...
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
This blocks rolling build: https://codereview.chromium.org/2289063002
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [gn] Allow overriding sanitizer suppression files BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ========== to ========== [gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ========== to ========== [gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org ========== to ========== [gn] Allow overriding sanitizer suppression files Port https://codereview.chromium.org/2267753002/ BUG=474921 TBR=jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/6b6d4c12f4572b726fe9059f7e21194b278a6e95 Cr-Commit-Position: refs/heads/master@{#39009} ==========
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6b6d4c12f4572b726fe9059f7e21194b278a6e95 Cr-Commit-Position: refs/heads/master@{#39009} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
