Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2290173006: Disallow non-namespaced use of base::Version. (Closed)

Created:
4 years, 3 months ago by pwnall
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow non-namespaced use of base::Version. This is a reland of https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910 BUG=639416 Committed: https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 Cr-Commit-Position: refs/heads/master@{#415940}

Patch Set 1 #

Patch Set 2 : Rebased against master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M base/version.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
pwnall
PTAL? I hope it'll go smoother this time around :)
4 years, 3 months ago (2016-08-31 20:42:00 UTC) #5
pwnall
On 2016/08/31 20:42:00, pwnall wrote: > PTAL? I hope it'll go smoother this time around ...
4 years, 3 months ago (2016-08-31 21:43:48 UTC) #6
pwnall
PTAL? I expect this CL to land smoothly this time around. I tried it against ...
4 years, 3 months ago (2016-09-01 04:00:59 UTC) #12
Nico
lgtm
4 years, 3 months ago (2016-09-01 13:35:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290173006/20001
4 years, 3 months ago (2016-09-01 13:35:48 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 13:39:45 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0 Cr-Commit-Position: refs/heads/master@{#415940}
4 years, 3 months ago (2016-09-01 13:41:49 UTC) #18
battre
4 years, 3 months ago (2016-09-01 14:21:53 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2305433003/ by battre@chromium.org.

The reason for reverting is: Breaks Google Chrome Linux x64 builder, see
http://crbug.com/639416#c16.

Powered by Google App Engine
This is Rietveld 408576698