Add some basic sanity tests to RootScroller for cases with remote frames.

Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
Committed: https://crrev.com/4e2f14c7363fe96556aff4f1e4ab44906ddbcd67
Cr-Commit-Position: refs/heads/master@{#416364}

[bokan, 2016-08-30 20:35:59]

Description was changed from

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
==========

to

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
==========

[bokan, 2016-08-30 20:36:00]

bokan@chromium.org changed reviewers:
+ lfg@chromium.org

[bokan, 2016-08-30 20:37:19]

Here's some tests. The RemoteMainFrame one fails without the earlier fix I
submitted and now passes.

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/RootScrollerTest.cpp (left):

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/RootScrollerTest.cpp:115: void
verticalScroll(float deltaY)
This was unused

[lfg, 2016-08-31 15:51:19]

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/RootScrollerTest.cpp (right):

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/RootScrollerTest.cpp:709: widget =
WebFrameWidget::create(&webWidgetClient, localFrame);
FrameTestHelpers::createLocalChild() already creates a WebFrameWidget. You can
get the widget through WebLocalFrameImpl::frameWidget().

[bokan, 2016-09-02 20:40:22]

Thanks, ptal

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/RootScrollerTest.cpp (right):

https://codereview.chromium.org/2290173004/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/RootScrollerTest.cpp:709: widget =
WebFrameWidget::create(&webWidgetClient, localFrame);
On 2016/08/31 15:51:19, lfg wrote:
> FrameTestHelpers::createLocalChild() already creates a WebFrameWidget. You can
> get the widget through WebLocalFrameImpl::frameWidget().

Done.

[lfg, 2016-09-02 20:58:44]

lgtm

[bokan, 2016-09-02 20:59:09]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:59:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:12:13]

Description was changed from

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
==========

to

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
==========

[commit-bot: I haz the power, 2016-09-02 22:12:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 22:14:49]

Description was changed from

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775
==========

to

==========
Add some basic sanity tests to RootScroller for cases with remote frames.

Added one test that deals with a remote iframe and another with a remote main
frame. RootScroller doesn't quite work in OOPIF scenarios yet but it's still
behind a flag so that's ok. These are mostly testing that we don't crash in the
normal case and that scrolling works ok.

BUG=641775

Committed: https://crrev.com/4e2f14c7363fe96556aff4f1e4ab44906ddbcd67
Cr-Commit-Position: refs/heads/master@{#416364}
==========

[commit-bot: I haz the power, 2016-09-02 22:14:50]

Patchset 2 (id:??) landed as
https://crrev.com/4e2f14c7363fe96556aff4f1e4ab44906ddbcd67
Cr-Commit-Position: refs/heads/master@{#416364}