src/api.cc - Issue 2290173003: Revert of Release streamed script resources after it was compiled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2290173003: Revert of Release streamed script resources after it was compiled (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 09a8524e9304f5e0edf5e293bf3dc16504c03cfb..514ff08183a0a4464afd6a37974c2476da1cc44a 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -2194,10 +2194,9 @@

}

has_pending_exception = result.is_null();

if (has_pending_exception) isolate->ReportPendingMessages();

- source->Release();

RETURN_ON_FAILED_EXECUTION(Script);

+ source->info->clear_script(); // because script goes out of scope.

Local<UnboundScript> generic = ToApiHandle<UnboundScript>(result);

if (generic.IsEmpty()) return Local<Script>();

« no previous file with comments | « no previous file | src/background-parsing-task.h » ('j') | no next file with comments »