Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2290173003: Revert of Release streamed script resources after it was compiled (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Release streamed script resources after it was compiled (patchset #1 id:1 of https://codereview.chromium.org/2297523002/ ) Reason for revert: Seems to break webkit unit tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9360 https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/5503 Original issue's description: > Release streamed script resources after it was compiled > > Otherwise, we'd hold on to the resources until the embedder frees them > which might take a long time > > R=marja@chromium.org,verwaest@chromium.org > BUG= > > Committed: https://crrev.com/877dac34465c018bb534b7781fbe242ae4e33c32 > Cr-Commit-Position: refs/heads/master@{#38999} TBR=marja@chromium.org,verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/08d1aa636477987663093339d2744b8514a70f65 Cr-Commit-Position: refs/heads/master@{#39012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M src/api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/background-parsing-task.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Release streamed script resources after it was compiled
4 years, 3 months ago (2016-08-30 12:37:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290173003/1
4 years, 3 months ago (2016-08-30 12:37:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 12:37:57 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 12:38:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08d1aa636477987663093339d2744b8514a70f65
Cr-Commit-Position: refs/heads/master@{#39012}

Powered by Google App Engine
This is Rietveld 408576698