Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2290163002: Revert of Update V8 DEPS. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #1 id:1 of https://codereview.chromium.org/2289063002/ ) Reason for revert: Breaks tsan build generation: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11441 Original issue's description: > Update V8 DEPS. > > Rolling v8/build to 52f474cdb9e67007b938fd4a47220cb3c012e5e8 > > Rolling v8/third_party/WebKit/Source/platform/inspector_protocol to 84d90b2cc3f01a39bf73a8119a5cec0337d00c9f > > Rolling v8/tools/clang to 3e1948978834c16073c1b076410df1a80adda1f5 > > Rolling v8/tools/mb to ac239cc82ef08858d6f2b75216dd13afcdbc6ac3 > > TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/3b8a2e5129fec64674bb0191cba5aa4592d08d5f > Cr-Commit-Position: refs/heads/master@{#38995} TBR=hablich@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/afbc4578afb574f62936e76b66fc5fb90567b1b4 Cr-Commit-Position: refs/heads/master@{#38998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Update V8 DEPS.
4 years, 3 months ago (2016-08-30 09:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290163002/1
4 years, 3 months ago (2016-08-30 09:36:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:36:26 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:37:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afbc4578afb574f62936e76b66fc5fb90567b1b4
Cr-Commit-Position: refs/heads/master@{#38998}

Powered by Google App Engine
This is Rietveld 408576698