Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2290143002: Convert editing/selection/replace-selection-1.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/replace-selection-1.html to use w3c test harness This patch converts "editing/selection/replace-selection-1.html" to use w3c test harness to simplify test script for improving readability, and rename to "editing/inserting/insert_html_to_replace_selection.html" since this test tests "insertHTML" command instead of selection itself. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/d42d2828663c573017ed31a801278af3b9bf445c Cr-Commit-Position: refs/heads/master@{#415562}

Patch Set 1 : 2016-08-30T17:42:16 #

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-08-30 09:31:22 UTC) #5
yoichio
lgtm
4 years, 3 months ago (2016-08-31 03:53:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290143002/1
4 years, 3 months ago (2016-08-31 03:56:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 05:10:45 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:12:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d42d2828663c573017ed31a801278af3b9bf445c
Cr-Commit-Position: refs/heads/master@{#415562}

Powered by Google App Engine
This is Rietveld 408576698