Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java

Issue 2290133002: Make WebView keep keyboard when losing focus (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java
index f2178a00391894a082545be72544ced0dde16d64..507a24b300b0501bfa80a48f19d4b67ba2ba5e0f 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java
@@ -51,9 +51,8 @@ public class ContentViewCoreFocusTest extends ContentShellTestBase {
@UiThreadTest
@RerunWithUpdatedContainerView
@SmallTest
- public void testHideImeOnLosingFocus() throws Throwable {
- // Test the IME window is hidden from the content view when the content
- // view loses its focus
+ public void testDoNotHideImeOnLosingFocus() throws Throwable {
+ // Tests that the IME window does not get hidden when the content view loses its focus.
final ContentViewCore contentViewCore = getContentViewCore();
final View view = contentViewCore.getContainerView();
assertTrue(view.requestFocus());
@@ -68,8 +67,7 @@ public class ContentViewCoreFocusTest extends ContentShellTestBase {
assertTrue(urlBox.requestFocus());
- // Now another view has taken focus. The original view loses its focus
- // and the input method window should be hidden
- assertTrue(immw.isHidden());
+ // When another view (URL box) takes focus, we do not hide the IME window.
+ assertFalse(immw.isHidden());
Changwan Ryu 2016/10/19 05:10:21 Hmm... This test depends on the real behavior of t
yabinh 2016/10/24 01:40:57 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698