Make WebView keep keyboard when losing focus

content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.res.Configuration;
 import android.os.Build;
 import android.os.ResultReceiver;
 import android.os.SystemClock;
@@ skipping 329 matching lines @@
         if (mNativeImeAdapterAndroid != 0) {
             nativeResetImeAdapter(mNativeImeAdapterAndroid);
         }
         if (nativeImeAdapter != 0) {
             nativeAttachImeAdapter(nativeImeAdapter);
         }
         mNativeImeAdapterAndroid = nativeImeAdapter;
         if (nativeImeAdapter != 0) {
             createInputConnectionFactory();
         }
+        resetAndHideKeyboard();
     }
 
     /**
      * Show soft keyboard only if it is the current keyboard configuration.
      */
     private void showSoftKeyboard() {
         if (DEBUG_LOGS) Log.w(TAG, "showSoftKeyboard");
         mInputMethodManagerWrapper.showSoftInput(
                 mViewEmbedder.getAttachedView(), 0, mViewEmbedder.getNewShowKeyboardReceiver());
         if (mViewEmbedder.getAttachedView().getResources().getConfiguration().keyboard
                 != Configuration.KEYBOARD_NOKEYS) {
             mViewEmbedder.onKeyboardBoundsUnchanged();
         }
     }
 
     /**
      * Hide soft keyboard.
      */
     private void hideKeyboard() {
         if (DEBUG_LOGS) Log.w(TAG, "hideKeyboard");
         View view = mViewEmbedder.getAttachedView();
-        if (mInputMethodManagerWrapper.isActive(view)) {

[Changwan Ryu, 2016/10/19 05:10:21]

Is this really causing flakiness in test with onDetachedFromWindow approach as
well? If so in what way? In CompositorViewHolder, we remove a view first and
then add a new view. I don't understand why this is needed. Could you look into
it a bit more?

At the minimum, please make a separate method instead of using this. There's
some risk in not checking activeness of the view.

[yabinh, 2016/10/24 01:40:57]

Still flaky, but it's because of the test itself, not the product. If we use
CriteriaHelper instead of CallbackHelper, we can solve that.

-            // NOTE: we should not set ResultReceiver here. Otherwise, IMM will own ContentViewCore
-            // and ImeAdapter even after input method goes away and result gets received.
-            mInputMethodManagerWrapper.hideSoftInputFromWindow(view.getWindowToken(), 0, null);
-        }
+        // NOTE: we should not set ResultReceiver here. Otherwise, IMM will own ContentViewCore
+        // and ImeAdapter even after input method goes away and result gets received.
+        mInputMethodManagerWrapper.hideSoftInputFromWindow(view.getWindowToken(), 0, null);
         // Detach input connection by returning null from onCreateInputConnection().
         if (mTextInputType == TextInputType.NONE && mInputConnection != null) {
             restartInput();
         }
     }
 
     /**
      * Call this when keyboard configuration has changed.
      */
     public void onKeyboardConfigurationChanged(Configuration newConfig) {
@@ skipping 34 matching lines @@
     public void onViewAttachedToWindow() {
         if (mInputConnectionFactory != null) {
             mInputConnectionFactory.onViewAttachedToWindow();
         }
     }
 
     /**
      * Call this when view is detached from window
      */
     public void onViewDetachedFromWindow() {
+        resetAndHideKeyboard();

[Changwan Ryu, 2016/10/19 05:10:21]

As we talked offline, I now prefer this approach because it may cover unexpected
scenarios such as removing container view for some UX effects.
Could you add some comment, though? Something like the following should suffice:

// Currently, the view is removed when you select another tab in
CompositorViewHolder.
InputMethodManager does not automatically hide keyboard even when view is
removed, so we add additional logic here.

         if (mInputConnectionFactory != null) {
             mInputConnectionFactory.onViewDetachedFromWindow();
         }
     }
 
     /**
      * Call this when view's focus has changed.
      * @param gainFocus True if we're gaining focus.
      */
     public void onViewFocusChanged(boolean gainFocus) {
         if (DEBUG_LOGS) Log.w(TAG, "onViewFocusChanged: gainFocus [%b]", gainFocus);
-        if (!gainFocus) resetAndHideKeyboard();
         if (mInputConnectionFactory != null) {
             mInputConnectionFactory.onViewFocusChanged(gainFocus);
         }
     }
 
     /**
      * Move cursor to the end of the current selection.
      */
     public void moveCursorToSelectionEnd() {
         if (DEBUG_LOGS) Log.w(TAG, "movecursorToEnd");
@@ skipping 347 matching lines @@
             int before, int after);
     private native void nativeResetImeAdapter(long nativeImeAdapterAndroid);
     private native boolean nativeRequestTextInputStateUpdate(
             long nativeImeAdapterAndroid);
     private native boolean nativeBeginBatchEdit(long nativeImeAdapterAndroid);
     private native boolean nativeEndBatchEdit(long nativeImeAdapterAndroid);
     private native void nativeRequestCursorUpdate(long nativeImeAdapterAndroid,
             boolean immediateRequest, boolean monitorRequest);
     private native boolean nativeIsImeThreadEnabled(long nativeImeAdapterAndroid);
 }