Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: runtime/bin/eventhandler_macos.cc

Issue 22901017: Always initialize the EventHandler in the standalone. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Simplify impl and don't call Stop (other isolates may still be running). Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_MACOS) 6 #if defined(TARGET_OS_MACOS)
7 7
8 #include "bin/eventhandler.h" 8 #include "bin/eventhandler.h"
9 9
10 #include <errno.h> // NOLINT 10 #include <errno.h> // NOLINT
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 } 177 }
178 178
179 179
180 void EventHandlerImplementation::WakeupHandler(intptr_t id, 180 void EventHandlerImplementation::WakeupHandler(intptr_t id,
181 Dart_Port dart_port, 181 Dart_Port dart_port,
182 int64_t data) { 182 int64_t data) {
183 InterruptMessage msg; 183 InterruptMessage msg;
184 msg.id = id; 184 msg.id = id;
185 msg.dart_port = dart_port; 185 msg.dart_port = dart_port;
186 msg.data = data; 186 msg.data = data;
187 // WriteToBlocking will write up to 512 bytes atomically, and since our msg
188 // is smaller than 512, we don't need a thread lock.
189 // See: http://linux.die.net/man/7/pipe, section 'Pipe_buf'.
Ivan Posva 2013/08/23 00:14:16 It is a bit questionable quoting a Linux man page
Anders Johnsen 2013/08/23 05:15:27 You are right. I was not able to find it in a mac
187 intptr_t result = 190 intptr_t result =
188 FDUtils::WriteToBlocking(interrupt_fds_[1], &msg, kInterruptMessageSize); 191 FDUtils::WriteToBlocking(interrupt_fds_[1], &msg, kInterruptMessageSize);
189 if (result != kInterruptMessageSize) { 192 if (result != kInterruptMessageSize) {
190 if (result == -1) { 193 if (result == -1) {
191 perror("Interrupt message failure:"); 194 perror("Interrupt message failure:");
192 } 195 }
193 FATAL1("Interrupt message failure. Wrote %" Pd " bytes.", result); 196 FATAL1("Interrupt message failure. Wrote %" Pd " bytes.", result);
194 } 197 }
195 } 198 }
196 199
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 460
458 uint32_t EventHandlerImplementation::GetHashmapHashFromFd(intptr_t fd) { 461 uint32_t EventHandlerImplementation::GetHashmapHashFromFd(intptr_t fd) {
459 // The hashmap does not support keys with value 0. 462 // The hashmap does not support keys with value 0.
460 return dart::Utils::WordHash(fd + 1); 463 return dart::Utils::WordHash(fd + 1);
461 } 464 }
462 465
463 } // namespace bin 466 } // namespace bin
464 } // namespace dart 467 } // namespace dart
465 468
466 #endif // defined(TARGET_OS_MACOS) 469 #endif // defined(TARGET_OS_MACOS)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698