Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: runtime/bin/eventhandler_linux.cc

Issue 22901017: Always initialize the EventHandler in the standalone. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Simplify impl and don't call Stop (other isolates may still be running). Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include "bin/eventhandler.h" 8 #include "bin/eventhandler.h"
9 9
10 #include <errno.h> // NOLINT 10 #include <errno.h> // NOLINT
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 158 }
159 159
160 160
161 void EventHandlerImplementation::WakeupHandler(intptr_t id, 161 void EventHandlerImplementation::WakeupHandler(intptr_t id,
162 Dart_Port dart_port, 162 Dart_Port dart_port,
163 int64_t data) { 163 int64_t data) {
164 InterruptMessage msg; 164 InterruptMessage msg;
165 msg.id = id; 165 msg.id = id;
166 msg.dart_port = dart_port; 166 msg.dart_port = dart_port;
167 msg.data = data; 167 msg.data = data;
168 // WriteToBlocking will write up to 512 bytes atomically, and since our msg
169 // is smaller than 512, we don't need a thread lock.
170 // See: http://linux.die.net/man/7/pipe, section 'Pipe_buf'.
Ivan Posva 2013/08/23 00:14:16 You should probably ASSERT(kInterruptMessageSize <
Anders Johnsen 2013/08/23 05:15:27 Good idea.
168 intptr_t result = 171 intptr_t result =
169 FDUtils::WriteToBlocking(interrupt_fds_[1], &msg, kInterruptMessageSize); 172 FDUtils::WriteToBlocking(interrupt_fds_[1], &msg, kInterruptMessageSize);
170 if (result != kInterruptMessageSize) { 173 if (result != kInterruptMessageSize) {
171 if (result == -1) { 174 if (result == -1) {
172 perror("Interrupt message failure:"); 175 perror("Interrupt message failure:");
173 } 176 }
174 FATAL1("Interrupt message failure. Wrote %" Pd " bytes.", result); 177 FATAL1("Interrupt message failure. Wrote %" Pd " bytes.", result);
175 } 178 }
176 } 179 }
177 180
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 449
447 uint32_t EventHandlerImplementation::GetHashmapHashFromFd(intptr_t fd) { 450 uint32_t EventHandlerImplementation::GetHashmapHashFromFd(intptr_t fd) {
448 // The hashmap does not support keys with value 0. 451 // The hashmap does not support keys with value 0.
449 return dart::Utils::WordHash(fd + 1); 452 return dart::Utils::WordHash(fd + 1);
450 } 453 }
451 454
452 } // namespace bin 455 } // namespace bin
453 } // namespace dart 456 } // namespace dart
454 457
455 #endif // defined(TARGET_OS_LINUX) 458 #endif // defined(TARGET_OS_LINUX)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698