Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: trunk/src/ppapi/proxy/file_io_resource.cc

Issue 22901012: Revert 218305 "Pepper: Move FileRef to the "new" resource proxy." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ppapi/proxy/file_io_resource.h ('k') | trunk/src/ppapi/proxy/file_ref_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ppapi/proxy/file_io_resource.cc
===================================================================
--- trunk/src/ppapi/proxy/file_io_resource.cc (revision 218542)
+++ trunk/src/ppapi/proxy/file_io_resource.cc (working copy)
@@ -111,13 +111,9 @@
if (rv != PP_OK)
return rv;
- // Take a reference on the FileRef resource while we're opening the file; we
- // don't want the plugin destroying it during the Open operation.
- file_ref_ = file_ref;
-
Call<PpapiPluginMsg_FileIO_OpenReply>(RENDERER,
PpapiHostMsg_FileIO_Open(
- file_ref,
+ enter.resource()->host_resource().host_resource(),
open_flags),
base::Bind(&FileIOResource::OnPluginMsgOpenFileComplete, this,
callback));
@@ -414,9 +410,6 @@
const ResourceMessageReplyParams& params) {
DCHECK(state_manager_.get_pending_operation() ==
FileIOStateManager::OPERATION_EXCLUSIVE);
-
- // Release the FileRef resource.
- file_ref_ = 0;
if (params.result() == PP_OK)
state_manager_.SetOpenSucceed();
« no previous file with comments | « trunk/src/ppapi/proxy/file_io_resource.h ('k') | trunk/src/ppapi/proxy/file_ref_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698