Fix scoping of function declarations in eval inside non-trivial local scope

Fix scoping of function declarations in eval inside non-trivial local scope

R=mstarzinger@chromium.org
BUG=v8:2594
Committed: http://code.google.com/p/v8/source/detail?r=16286

[Michael Starzinger, 2013-08-23 08:56:30]

LGTM with comments.

https://codereview.chromium.org/22901010/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/22901010/diff/1/src/parser.cc#newcode544
src/parser.cc:544: top_scope_(NULL),
Missing initialization of original_scope_(NULL) here.

https://codereview.chromium.org/22901010/diff/1/src/parser.cc#newcode4290
src/parser.cc:4290: //   try {throw 1} catch (x) { eval("function g() { return x
}") }
nit: A few white spaces missing here and in the line above.

[rossberg, 2013-08-23 09:09:21]

https://codereview.chromium.org/22901010/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/22901010/diff/1/src/parser.cc#newcode544
src/parser.cc:544: top_scope_(NULL),
On 2013/08/23 08:56:30, Michael Starzinger wrote:
> Missing initialization of original_scope_(NULL) here.

Done.

https://codereview.chromium.org/22901010/diff/1/src/parser.cc#newcode4290
src/parser.cc:4290: //   try {throw 1} catch (x) { eval("function g() { return x
}") }
On 2013/08/23 08:56:30, Michael Starzinger wrote:
> nit: A few white spaces missing here and in the line above.

Done.

[rossberg, 2013-08-23 09:25:52]

Committed patchset #3 manually as r16286 (presubmit successful).