Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2290063002: Added diagrams to installer README (Closed)

Created:
4 years, 3 months ago by Anna Zeng
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added diagrams to installer README Committed: https://crrev.com/66846f121950c82e20e81979f036e45f282125d1 Cr-Commit-Position: refs/heads/master@{#415307}

Patch Set 1 #

Total comments: 4

Patch Set 2 : LGTM edits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -23 lines) Patch
M chrome/installer/mac/app/README.md View 1 2 chunks +132 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Anna Zeng
Looking for feedback!
4 years, 3 months ago (2016-08-30 14:54:24 UTC) #2
Elly Fong-Jones
lgtm :) https://codereview.chromium.org/2290063002/diff/1/chrome/installer/mac/app/README.md File chrome/installer/mac/app/README.md (right): https://codereview.chromium.org/2290063002/diff/1/chrome/installer/mac/app/README.md#newcode4 chrome/installer/mac/app/README.md:4: Mac app the user first downloads when ...
4 years, 3 months ago (2016-08-30 15:09:45 UTC) #3
Anna Zeng
https://codereview.chromium.org/2290063002/diff/1/chrome/installer/mac/app/README.md File chrome/installer/mac/app/README.md (right): https://codereview.chromium.org/2290063002/diff/1/chrome/installer/mac/app/README.md#newcode4 chrome/installer/mac/app/README.md:4: Mac app the user first downloads when he/she clicks ...
4 years, 3 months ago (2016-08-30 15:16:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290063002/20001
4 years, 3 months ago (2016-08-30 15:16:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 16:05:50 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:07:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66846f121950c82e20e81979f036e45f282125d1
Cr-Commit-Position: refs/heads/master@{#415307}

Powered by Google App Engine
This is Rietveld 408576698