Remove some unused theming code for GTK.

Remove some unused theming code for GTK.

This stuff is all unused with Material Design enabled. I'm not sure if
this causes collateral damage to the GTK3 build. Hopefully, if it does,
it will be easy to resurrect that functionality.

BUG=none

Committed: https://crrev.com/974e48d2d63f7f8587628e1616792b5bd644c135
Cr-Commit-Position: refs/heads/master@{#416039}

[Evan Stade, 2016-08-30 01:05:15]

estade@chromium.org changed reviewers:
+ erg@chromium.org

[Evan Stade, 2016-08-30 01:05:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Elliot Glaysher, 2016-08-30 17:40:04]

https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:1026:
theme->GetChromeStyleColor("inactive-frame-color", &temp_color);
I'm pretty sure this will at least visually break the GTK3 stuff. What's going
on with GetChromeStyleColor is that in a GTK2 ifdef, it uses a GTK2 specific API
call to look up style information in the gtk2rc file, which lets a gtk theme
author inject colors.

This probably compiles, but the frame will probably be totally busted.

In the #else/gtk3 block here, we're getting the frame image that gtk3 would
render, and are then just grabbing a color out of it. GenerateFrameImage() is
grabbing the pixels from an actual GtkHeaderBar for this.

If you just leave GenerateFrameImage(), this will all probably work.

[Evan Stade, 2016-08-31 01:15:47]

https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:1026:
theme->GetChromeStyleColor("inactive-frame-color", &temp_color);
On 2016/08/30 17:40:04, Elliot Glaysher wrote:
> I'm pretty sure this will at least visually break the GTK3 stuff. What's going
> on with GetChromeStyleColor is that in a GTK2 ifdef, it uses a GTK2 specific
API
> call to look up style information in the gtk2rc file, which lets a gtk theme
> author inject colors.
> 
> This probably compiles, but the frame will probably be totally busted.
> 
> In the #else/gtk3 block here, we're getting the frame image that gtk3 would
> render, and are then just grabbing a color out of it. GenerateFrameImage() is
> grabbing the pixels from an actual GtkHeaderBar for this.
> 
> If you just leave GenerateFrameImage(), this will all probably work.

ah, that's more or less what I suspected, but I was wary of hoping it would
"just work" without having a means to test it. Updated to preserve this
functionality, fingers crossed.

[Elliot Glaysher, 2016-08-31 17:53:21]

lgtm

https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:88: class GtkThemeIconSource : public
gfx::ImageSkiaSource {
Are you able to delete this class now? Gtk2UI::GenerateGtkThemeImage() looked
like the only user.

[Evan Stade, 2016-08-31 20:45:28]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-08-31 20:45:39]

https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right):

https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtk2ui/gtk2_ui.cc:88: class GtkThemeIconSource : public
gfx::ImageSkiaSource {
On 2016/08/31 17:53:21, Elliot Glaysher wrote:
> Are you able to delete this class now? Gtk2UI::GenerateGtkThemeImage() looked
> like the only user.

Done.

[commit-bot: I haz the power, 2016-08-31 20:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-08-31 20:48:47]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-08-31 20:48:51]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-08-31 20:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2290053002/#ps60001
(title: "remove GtkThemeIconSource")

[commit-bot: I haz the power, 2016-08-31 20:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:33:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-09-01 20:03:13]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:04:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:44:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-01 20:46:59]

Description was changed from

==========
Remove some unused theming code for GTK.

This stuff is all unused with Material Design enabled. I'm not sure if
this causes collateral damage to the GTK3 build. Hopefully, if it does,
it will be easy to resurrect that functionality.

BUG=none
==========

to

==========
Remove some unused theming code for GTK.

This stuff is all unused with Material Design enabled. I'm not sure if
this causes collateral damage to the GTK3 build. Hopefully, if it does,
it will be easy to resurrect that functionality.

BUG=none

Committed: https://crrev.com/974e48d2d63f7f8587628e1616792b5bd644c135
Cr-Commit-Position: refs/heads/master@{#416039}
==========

[commit-bot: I haz the power, 2016-09-01 20:47:00]

Patchset 4 (id:??) landed as
https://crrev.com/974e48d2d63f7f8587628e1616792b5bd644c135
Cr-Commit-Position: refs/heads/master@{#416039}