Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2290053002: Remove some unused theming code for GTK. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused theming code for GTK. This stuff is all unused with Material Design enabled. I'm not sure if this causes collateral damage to the GTK3 build. Hopefully, if it does, it will be easy to resurrect that functionality. BUG=none Committed: https://crrev.com/974e48d2d63f7f8587628e1616792b5bd644c135 Cr-Commit-Position: refs/heads/master@{#416039}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : attempt to preserve gtk3 functionality #

Total comments: 2

Patch Set 4 : remove GtkThemeIconSource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -403 lines) Patch
M chrome/browser/themes/custom_theme_supplier.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 6 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 2 3 12 chunks +57 lines, -364 lines 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Evan Stade
4 years, 3 months ago (2016-08-30 01:05:15 UTC) #2
Elliot Glaysher
https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode1026 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:1026: theme->GetChromeStyleColor("inactive-frame-color", &temp_color); I'm pretty sure this will at least ...
4 years, 3 months ago (2016-08-30 17:40:04 UTC) #4
Evan Stade
https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2290053002/diff/20001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode1026 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:1026: theme->GetChromeStyleColor("inactive-frame-color", &temp_color); On 2016/08/30 17:40:04, Elliot Glaysher wrote: > ...
4 years, 3 months ago (2016-08-31 01:15:47 UTC) #5
Elliot Glaysher
lgtm https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode88 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:88: class GtkThemeIconSource : public gfx::ImageSkiaSource { Are you ...
4 years, 3 months ago (2016-08-31 17:53:21 UTC) #6
Evan Stade
https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2290053002/diff/40001/chrome/browser/ui/libgtk2ui/gtk2_ui.cc#newcode88 chrome/browser/ui/libgtk2ui/gtk2_ui.cc:88: class GtkThemeIconSource : public gfx::ImageSkiaSource { On 2016/08/31 17:53:21, ...
4 years, 3 months ago (2016-08-31 20:45:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290053002/60001
4 years, 3 months ago (2016-08-31 20:49:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/290180)
4 years, 3 months ago (2016-08-31 22:33:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290053002/60001
4 years, 3 months ago (2016-09-01 20:04:11 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-01 20:44:34 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/974e48d2d63f7f8587628e1616792b5bd644c135 Cr-Commit-Position: refs/heads/master@{#416039}
4 years, 3 months ago (2016-09-01 20:47:00 UTC) #20
sL1pKn07
4 years, 3 months ago (2016-09-09 16:50:16 UTC) #21
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698